Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Actually force a / in the path for ext crates
If the library is in the working directory, its path won't have a "/" which will cause dlopen to search /usr/lib etc. It turns out that Path auto-normalizes during joins so Path::new(".").join(path) is actually a no-op.
- Loading branch information
1e20960
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at sfackler@1e20960
1e20960
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging sfackler/rust/macro-crate-path = 1e20960 into auto
1e20960
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sfackler/rust/macro-crate-path = 1e20960 merged ok, testing candidate = 5512fb4
1e20960
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3658
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-c/builds/1500
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-t/builds/1502
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3659
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2759
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2765
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3673
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2761
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2767
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3675
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2761
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2766
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/2835
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/3665
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/2766
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2771
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/3436
1e20960
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 5512fb4