Auto merge of #64262 - Xanewok:always-validate-hir-id-for-typeck-tabl…

…es, r=<try> [DONT MERGE] Always validate HIR ID for TypeckTables ...and not only with `debug_assertions` compiled in - #64250 (comment). cc @Mark-Simulacrum @michaelwoerister Let's do a try run to see if this impacts perf anyhow? r? @ghost
rust-lang · Sep 7, 2019 · 1c025bb · 1c025bb
2 parents ef54f57 + f6ae4a4
commit 1c025bb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/librustc/ty/context.rs b/src/librustc/ty/context.rs
@@ -207,7 +207,7 @@ pub struct LocalTableInContext<'a, V> {
 fn validate_hir_id_for_typeck_tables(local_id_root: Option<DefId>,
                                      hir_id: hir::HirId,
                                      mut_access: bool) {
-    if cfg!(debug_assertions) {
+    // if cfg!(debug_assertions) {
         if let Some(local_id_root) = local_id_root {
             if hir_id.owner != local_id_root.index {
                 ty::tls::with(|tcx| {
@@ -228,7 +228,7 @@ fn validate_hir_id_for_typeck_tables(local_id_root: Option<DefId>,
                 bug!("access to invalid TypeckTables")
             }
         }
-    }
+    // }
 }
 
 impl<'a, V> LocalTableInContext<'a, V> {

diff --git a/src/tools/clippy b/src/tools/clippy
diff --git a/src/tools/miri b/src/tools/miri