Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version #178

Merged
merged 1 commit into from
Nov 1, 2016
Merged

Bump version #178

merged 1 commit into from
Nov 1, 2016

Conversation

ryuslash
Copy link
Contributor

Sorry if this is too forward, but it was suggested in #87 that someone who wants a (new) version to be released/tagged should just open a pull request, so that's what I'm doing. My hope is that you will create a git tag for this version so that it shows up in Melpa Stable, or at the very least get the release discussion going again. If you don't, then this pull request really has no meaning.

I thought I'd stay conservative with the new version number, as I just wanted to try some rust in Emacs today and found that rust-mode wasn't available on melpa stable and don't actually know anything about this project yet (in terms of goals, open issues, etc.). If this project is already in a state where you feel that all the initial goals of the project have been reached and no backward-incompatible changes will happen in the forseable future, then the version could of course be changed to 1.0.0 instead. All of this is assuming that you (will want to) adhere to semantic versioning, if you don't then any version number will do.

Creating a release isn't just about users wanting to install rust-mode while using melpa stable, but also about at least 2 packages (racer and cargo) which are in melpa stable, but can't be installed due to depending on an unavailable package (rust-mode).

In case you care about completeness, commits 4c1eab5 and 5afc8ab may also be prime candidates for tagging as they changed the versions to 0.2.0 and 0.1.0 respectively.

So whatever you do, please tag a release.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@pnkfelix
Copy link
Member

pnkfelix commented Oct 27, 2016

reassigning to @MicahChalmer ; you know a lot more about this than I do.

@MicahChalmer
Copy link
Contributor

Well I know as much as I said in #87. It seems like there's a lot of people asking for this (somebody else opened #179 just after this was filed), and nobody objected to the proposal at the end of the discussion in #87. So let's go with that. I'll accept this as the first such pull request, and add the tag.

@MicahChalmer MicahChalmer merged commit e327658 into rust-lang:master Nov 1, 2016
This was referenced Nov 1, 2016
@ryuslash
Copy link
Contributor Author

ryuslash commented Nov 1, 2016

Thank you! It's now on melpa stable: http://stable.melpa.org/#/rust-mode

@brson
Copy link
Contributor

brson commented Nov 8, 2016

Thanks @ryuslash !

@pnkfelix pnkfelix mentioned this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants