-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variety of improvements #20
Conversation
…lled-prefix Required to distingish component files from other files in future commits.
Current design isn't right - needs to be per-component. Questionable feature.
This was introduced by earlier destdir fixes, and was due to extra slashes being prepended to paths in non-destdir cases.
It's possible for multiple components to contain the same file. Keeping the components separate is more convenient for other purposes.
It only takes a dir copy now to merge in components.
By marking the component installed before installing, an uninstall should succeed at rolling back a partially-successful install. Similar rationale for setting the installer version number before installing.
@brson: no appropriate reviewer found, use r? to override |
The one thing I wanted but decided not to add because of complexity is 'negative component deps', which would allow multirust to uninstall existing rust's without causing havok. |
👾 |
@alexcrichton For the record, no. The installer normally uninstalls everything it's previously installed before upgrading. The backups only happen in exceptional circumstances when some other agent has put files in our way. |
Highlights:
uninstall.sh
script.--components
flag for selecting which components to install/uninstall, as well as a--list-components
flag.--verbose
is provided.-f
where it isn't needed.Output of installing rust currently looks like
Closes #15, #13, #12, #9, #8, #6, #5