Add manifest on Windows to avoid UAC popups #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rename (#113) rust installer triggers Windows
bugfeature that makes 32-bit binaries with specific strings automatically trigger UAC prompt (https://learn.microsoft.com/en-us/previous-versions/aa905330(v=msdn.10)#installer-detection).This is an issue when running program in non-elevated shell like we do at MSYS2: msys2/MINGW-packages#9091 (comment), For that reason we carry this PR as downstream patch.
Here is how manifest is configured by the default with
embed-manifestcrate: https://docs.rs/embed-manifest/1.3.1/embed_manifest/fn.new_manifest.html