Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List thumb targets as tier 1 #217

Closed
wants to merge 1 commit into from
Closed

List thumb targets as tier 1 #217

wants to merge 1 commit into from

Conversation

jonas-schievink
Copy link
Contributor

@jonas-schievink jonas-schievink commented May 7, 2019

@kennytm
Copy link
Member

kennytm commented May 7, 2019

The thumb targets are certainly not tier-1 (if CI testing is the only condition the arm and aarch64 etc would count as tier-1 too).

@jonas-schievink
Copy link
Contributor Author

The conditions for Tier 1 are:

  • Official binary releases are provided for the platform.
  • Automated testing is set up to run tests for the platform.
  • Landing changes to the rust-lang/rust repository’s master branch is gated on tests passing.
  • Documentation for how to use and how to build the platform is available.

These all seem fulfilled for the thumb targets to me. If that is also the case for arm and aarch64, then they should probably also be moved to Tier 1.

@shepmaster
Copy link
Member

My understanding has always been that Tier 1 never "regresses" back to a lower tier. It effectively becomes part of Rust's "stable forever" guarantee.

To that end, being promoted to Tier 1 isn't just a set of checkboxes to meet.

@kennytm
Copy link
Member

kennytm commented May 7, 2019

We might demote i686-apple-darwin to lower tiers when we can no longer reliably use Xcode 9. Though I agree this checklist is insufficient, and the definition and content of each tier should need a review.

@shepmaster
Copy link
Member

demote i686-apple-darwin to lower tiers when we can no longer reliably use Xcode 9

Yes, I suppose if the vendor themselves basically sunsets a platform, that would be a reasonable event to demote Rust support for it. 😬

@jonas-schievink
Copy link
Contributor Author

The current tests run for thumb targets also seem extremely minimal so I'm on board with calling them Tier 2 for now. I'll also update all the other incorrect listings. Deciding on new Tier 1 platforms does sound like something the core team has to discuss. We've never added a new one. Is there any sort of process for this? Should I just open and nominate an issue in rust-lang/rust?

@jonas-schievink
Copy link
Contributor Author

Closing in favor of rust-lang/rust#60880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are thumb* targets really Tier 2?
3 participants