Skip to content

Conversation

@Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Nov 29, 2022

fixes #9935

This is stalled until the next sync. The impl in question can't be written on the pinned nightly.

changelog: Don't lint from_over_into for opaque types

@rustbot
Copy link
Collaborator

rustbot commented Nov 29, 2022

r? @flip1995

(rustbot has picked a reviewer for you, use r? to override)

@xFrednet xFrednet added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 29, 2022
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. r=me after the next sync (in case I forget)

@Jarcho
Copy link
Contributor Author

Jarcho commented Dec 2, 2022

@bors r=flip1995

@bors
Copy link
Contributor

bors commented Dec 2, 2022

📌 Commit 6ecdff0 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 2, 2022

⌛ Testing commit 6ecdff0 with merge b43c9f7...

@bors
Copy link
Contributor

bors commented Dec 2, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing b43c9f7 to master...

@bors bors merged commit b43c9f7 into rust-lang:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FP from_over_into: type_alias_impl_trait

5 participants