Skip to content

Conversation

@nahuakang
Copy link
Contributor

@nahuakang nahuakang commented Oct 17, 2022

Relates to Issue #9311 and PR #9426.
Should depend on #9659 but only optional.

This chapter is related to defining new lints. Once approved, we'll rebase it on master which has define_lints chapter.

changelog: Docs: Updated development documentation, a new section for writing tests was added.
#9668

r? @flip1995

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 17, 2022
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks pretty good. Maybe adding a section about more complex headers like aux-build, used for compiling using helper files / auxiliary crates.

- [Development](development/README.md)
- [Basics](development/basics.md)
- [Adding Lints](development/adding_lints.md)
- [Define Lints](development/define_lints.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A define_lints.md file is created with no contents, maybe a leftover from other PRs?

detect `foo` functions and emit a lint.

As we gradually implement our lint logic, we will keep running and improving UI tests
untilthe output turns into what we want it to be.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo.

Suggested change
untilthe output turns into what we want it to be.
until the output turns into what we want it to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants