-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add invalid_utf8_in_unchecked
#9105
Conversation
r? @Jarcho (rust-highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this is likely useless. Passing a constant to from_utf8_unchecked
is rather strange as it could have just been a string literal. On the other hand this is UB, so I guess it's justified.
6128a92
to
49f32d7
Compare
49f32d7
to
de646e1
Compare
Thank you. @bors r+ |
📌 Commit de646e1 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
changelog: Add [
invalid_utf8_in_unchecked
]closes: #629
Don't know how useful of a lint this is, just saw this was a really old issue 😄.