Optionally allow expect
and unwrap
in tests
#8802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #1015, except it makes the new behavior optional.
The reason for the msrv-related changes is as follows.
Rather than expand
check_methods
list of arguments, it seemed easier to makecheck_methods
a method ofMethods
, so thatcheck_methods
could accessMethods
' fields.check_methods
had anmsrv
parameter, which I consequently made a field ofMethods
. But, to avoid adding a lifetime parameter toMethods
, I made the field typeOption<RustcVersion>
instead of the parameter's existing type,Option<&RustcVersion>
. This seemed sensible sinceRustcVersion
implementsCopy
. But this broke a lot of code that expected anOption<&RustcVersion>
or&Option<RustcVersion>
. I changed all of those occurrences toOption<RustcVersion>
. IMHO, the code is better as a result of these changes, though.The msrv-related changes are in their own commit to (hopefully) ease review.
Closes #1015
changelog: optionally allow
expect
andunwrap
in testsr? @llogiq