Add lints drop_non_drop and forget_non_drop
#8630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Manishearth
approved these changes
Apr 6, 2022
|
@bors r+ |
|
📌 Commit 5cd711b has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Merged
bors
added a commit
that referenced
this pull request
Apr 11, 2022
fix typo fix typo in #8630 changelog: none
| /// Checks for calls to `std::mem::drop` with a value that does not implement `Drop`. | ||
| /// | ||
| /// ### Why is this bad? | ||
| /// Calling `std::mem::drop` is no different than dropping such a type. A different value may |
There was a problem hiding this comment.
Maybe the wording of this could be improved. It looks like it was copied and pasted from the forget lint and I think this description is confusing – yes std::mem::drop is in fact no different than dropping it, what’s the problem?
Indy2222
added a commit
to DigitalExtinction/Game
that referenced
this pull request
Jul 1, 2022
We started to get a Clippy error in CI: error: call to `std::mem::forget` with a value that does not implement `Drop`. Forgetting such a type is the same as dropping it --> crates/spawner/src/spawner.rs:19:10 | 19 | #[derive(Bundle)] | ^^^^^^ | = note: `-D clippy::forget-non-drop` implied by `-D warnings` note: argument has type `spawner::Spawn` --> crates/spawner/src/spawner.rs:19:10 | 19 | #[derive(Bundle)] | ^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_non_drop = note: this error originates in the derive macro `Bundle` (in Nightly builds, run with -Z macro-backtrace for more info) The failing lint was recently added in rust-lang/rust-clippy#8630. Unfortunately, it is not possible to disable linting of code generated by external macros rust-lang/rust-clippy#407. The issue was reported to Bevy team here bevyengine/bevy#5166.
Indy2222
added a commit
to DigitalExtinction/Game
that referenced
this pull request
Jul 1, 2022
We started to get a Clippy error in CI: error: call to `std::mem::forget` with a value that does not implement `Drop`. Forgetting such a type is the same as dropping it --> crates/spawner/src/spawner.rs:19:10 | 19 | #[derive(Bundle)] | ^^^^^^ | = note: `-D clippy::forget-non-drop` implied by `-D warnings` note: argument has type `spawner::Spawn` --> crates/spawner/src/spawner.rs:19:10 | 19 | #[derive(Bundle)] | ^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_non_drop = note: this error originates in the derive macro `Bundle` (in Nightly builds, run with -Z macro-backtrace for more info) The failing lint was recently added in rust-lang/rust-clippy#8630. Unfortunately, it is not possible to disable linting of code generated by external macros rust-lang/rust-clippy#407. The issues on Bevy site is tracked here bevyengine/bevy#4601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1897
changelog: Add lints
drop_non_dropandforget_non_drop