Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable `[new-without-default]` for new() methods that are marked… #8472

Conversation

Mastermindaxe
Copy link

… with '#[doc(hidden)]'

Fixes #8152

changelog: Disable [`new-without-default`] for new() methods that are marked with #[doc(hidden)]

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 25, 2022
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a quick test update and we can merge this.

tests/ui/new_without_default.rs Outdated Show resolved Hide resolved
@Mastermindaxe Mastermindaxe force-pushed the #8152_new-without-default_should_not_trigger_on_doc_hidden_items branch from 9c70c3e to 862211d Compare February 25, 2022 15:34
@flip1995
Copy link
Member

@bors r+

Thanks for the quick response!

@bors
Copy link
Contributor

bors commented Feb 25, 2022

📌 Commit 862211d has been approved by flip1995

@bors
Copy link
Contributor

bors commented Feb 25, 2022

⌛ Testing commit 862211d with merge 95897bf...

@bors
Copy link
Contributor

bors commented Feb 25, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 95897bf to master...

@bors bors merged commit 95897bf into rust-lang:master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new-without-default should not trigger on #[doc(hidden)] items
5 participants