Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofocus search input #8343

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Autofocus search input #8343

merged 1 commit into from
Jan 25, 2022

Conversation

robjtede
Copy link
Contributor

@robjtede robjtede commented Jan 24, 2022

changelog: autofocus filter input on Clippy Lints page

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 24, 2022
@robjtede robjtede marked this pull request as ready for review January 24, 2022 11:58
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reasons it seems not to work on chrome: version: 97.0.4692.99(Official Build) (x86_64)
Can you check it by cargo dev serve?

@robjtede
Copy link
Contributor Author

True, dynamic loading means the simple approach will not work.

@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jan 25, 2022

📌 Commit a8e1352 has been approved by giraffate

@bors
Copy link
Contributor

bors commented Jan 25, 2022

⌛ Testing commit a8e1352 with merge a26c412...

@bors
Copy link
Contributor

bors commented Jan 25, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing a26c412 to master...

@bors bors merged commit a26c412 into rust-lang:master Jan 25, 2022
@robjtede robjtede deleted the patch-1 branch January 25, 2022 13:25
@xFrednet
Copy link
Member

It works, thank you, @robjtede, I wanted this for some time now! 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants