Move return_self_not_must_use to pedantic
#8302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ p=1 Thanks! |
|
📌 Commit 6968382 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 17, 2022
…flip1995 Move `return_self_not_must_use` to `pedantic` r? `@flip1995` changelog: none
|
💔 Test failed - checks-action_dev_test |
xFrednet
force-pushed
the
0000-move-return-self-not-must-use
branch
from
6968382 to
2d3eb50
Compare
|
Ups, rustfmt complained @bors r=flip1995 |
|
📌 Commit 2d3eb50 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 23, 2022
…imulacrum [stable] 1.59.0 artifacts (second round) This backports (from 1.60, landed in rust-lang#93001): * Move return_self_not_must_use to pedantic rust-lang/rust-clippy#8302 Per a user report on the internals feedback thread, this lint is not behaving well in 1.59. cc `@rust-lang/clippy` -- this is a stable backport of a patch, which we'll likely want to land in fairly short order to be in time for the release Thursday. This PR also includes an adjustment to the release notes to reflect "Fix invalid special casing of the unreachable! macro rust-lang#93179". r? `@Mark-Simulacrum`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @flip1995
changelog: none