Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn disallowed_methods and disallowed_types by default #8261

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Warn disallowed_methods and disallowed_types by default #8261

merged 1 commit into from
Jan 11, 2022

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jan 10, 2022

Closes #7841

changelog: Moved [disallowed_methods] and [disallowed_types] to style

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 10, 2022
taiki-e
taiki-e commented Jan 10, 2022
View reviewed changes
clippy_lints/src/disallowed_methods.rs
@@ -49,7 +49,7 @@ declare_clippy_lint! {
/// ```
#[clippy::version = "1.49.0"]
pub DISALLOWED_METHODS,
nursery,
style,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if style is the right group (I felt like it is "user-defined code styles"), but I couldn't find another group that looked good. (restriction that #7841 originally proposed is allowed by default.)

@taiki-e taiki-e mentioned this pull request Jan 10, 2022
Closed
@flip1995
Copy link
Member

Yeah, I think style is fine here.

I would add a note to the What it does section, that says somehting like:

Note: Even though this lint is warn-by-default, it will only trigger if methods/types are defined in the clippy.toml file.

@taiki-e
Copy link
Member Author

taiki-e commented Jan 10, 2022

@flip1995 Thanks. I applied your suggestion.

@giraffate
Copy link
Contributor

@bors r+

It looks good, thanks!

@bors
Copy link
Contributor

bors commented Jan 10, 2022

📌 Commit 5f143c6 has been approved by giraffate

@bors
Copy link
Contributor

bors commented Jan 10, 2022

⌛ Testing commit 5f143c6 with merge 51282fc...

@bors
Copy link
Contributor

bors commented Jan 11, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 51282fc to master...

@bors bors merged commit 51282fc into rust-lang:master Jan 11, 2022
@taiki-e taiki-e deleted the disallowed branch January 11, 2022 01:09
@xxchan xxchan mentioned this pull request Mar 24, 2022
Closed
@taiki-e taiki-e mentioned this pull request Sep 20, 2023
Merged
bors added a commit that referenced this pull request Oct 21, 2023
@bors
Auto merge of #11539 - taiki-e:enforced-import-renames, r=Centri3
23af253 
Warn missing_enforced_import_renames by default

Similar to #8261 that did the same thing to disallowed_methods & disallowed_types.
This lint is also only triggered if import renames are defined in the `clippy.toml` file.

changelog: Moved [`missing_enforced_import_renames`] to `style` (Now warn-by-default)
[#11539](#11539)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giraffate giraffate giraffate approved these changes

Assignees

@giraffate giraffate

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable disallowed-method and disallowed-type by default
5 participants
@taiki-e @rust-highfive @flip1995 @giraffate @bors