-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clippy::use-self
warning in
src/main.rs`
#8216
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) soon. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the Pull Request, the change looks good to me. Before merging this, I'm interested how you found this. Our Dogfood test should have caught this in the CI, have you executed some other command? 🙃
I executed this command |
That's a good hint, looking at the dogfood test it seems like it also ignores the sources under test. That's good to know! Thank you 🙃 @bors r+ |
📌 Commit 19cfcd5 has been approved by |
Fix `clippy::use-self`` warning in ` src/main.rs` `ClippyCmd` warnings gets generated due to addition of `clippy::use-self`. This PR fixes that. ``` warning: unnecessary structure name repetition --> src/main.rs:99:9 | 99 | ClippyCmd { | ^^^^^^^^^ help: use the applicable keyword: `Self` | = note: `-W clippy::use-self` implied by `-W clippy::nursery` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self ```
💔 Test failed - checks-action_test |
BTW, I just noticed that your GH profile isn't linked to the commit. The email is probably different, this is not a problem, and it can be merged as it is, just wanted to point that out in case that was an accident. I'll wait for a response until I retry 🙃 (I fixed the changelog entry) |
I think |
Thanks for noticing. How did you find out that it's not linked properly? |
I changed setting in my github profile, the email address should be linked properly now. |
You can look at the commit in this PR if your picture shows up, and you can click on it, then it's correctly linked. (Like it is now) 👍 @bors retry |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
ClippyCmd
warnings gets generated due to addition ofclippy::use-self
. This PR fixes that.changelog: none