Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some false negatives for [single_char_pattern] #8077

Merged

Conversation

nixxquality
Copy link
Contributor

Please write a short comment explaining your change (or "none" for internal only changes)

changelog: Fix some false negatives for [single_char_pattern]

I noticed that clippy wasn't complaining about my usage of split_once("x") in a personal project so I updated the list of functions.

I had to update the test case for an unrelated issue because replace is now included in the list of functions to be linted.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @camsteffen (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 5, 2021
@nixxquality
Copy link
Contributor Author

What's up with these failing tests? I did test before I committed and I re-tested now as well and nothing fails locally.

@llogiq
Copy link
Contributor

llogiq commented Dec 5, 2021

It seems like our code doesn't live up to your improved requirements. The dogfood tests shows where updates are needed.

@nixxquality
Copy link
Contributor Author

How do I run those tests locally?
Following the instructions in basics.md to "only run dogfood tests" using cargo test --test dogfood doesn't produce any failing results.

@camsteffen
Copy link
Contributor

Not sure why cargo test didn't work, but CI is passing now! Changes look good. Please squash commits (or change the commit message to something like "Fix dogfood").

@nixxquality nixxquality force-pushed the single_char_pattern-false-negatives branch from 8eb1b8c to 01e302b Compare December 5, 2021 22:05
@camsteffen
Copy link
Contributor

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Dec 6, 2021

📌 Commit 01e302b has been approved by camsteffen

@bors
Copy link
Contributor

bors commented Dec 6, 2021

⌛ Testing commit 01e302b with merge a5d5976...

@bors
Copy link
Contributor

bors commented Dec 6, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing a5d5976 to master...

@bors bors merged commit a5d5976 into rust-lang:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants