-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some false negatives for [single_char_pattern
]
#8077
Fix some false negatives for [single_char_pattern
]
#8077
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @camsteffen (or someone else) soon. Please see the contribution instructions for more information. |
What's up with these failing tests? I did test before I committed and I re-tested now as well and nothing fails locally. |
It seems like our code doesn't live up to your improved requirements. The dogfood tests shows where updates are needed. |
How do I run those tests locally? |
Not sure why |
8eb1b8c
to
01e302b
Compare
Thanks! @bors r+ |
📌 Commit 01e302b has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Please write a short comment explaining your change (or "none" for internal only changes)
changelog: Fix some false negatives for [
single_char_pattern
]I noticed that clippy wasn't complaining about my usage of
split_once("x")
in a personal project so I updated the list of functions.I had to update the test case for an unrelated issue because replace is now included in the list of functions to be linted.