README: document that Clippy may change codegen
#8037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @camsteffen (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
What do you think about re-wording more of this section like I described here? |
camsteffen
added
S-waiting-on-author
ojeda
force-pushed
the
doc-codegen-change
branch
2 times, most recently
from
a006d4d to
82f69c3
Compare
|
PTAL. I also changed the usage sentence in a second commit to list the subsections properly. Not sure what was meant by "compiled from source", though. |
camsteffen
reviewed
Dec 14, 2021
Currently, `clippy-driver` may run codegen, but this is an implementation detail. See rust-lang#8035. Signed-off-by: Miguel Ojeda <[email protected]>
Removes the "compiled from source" bit, which is confusing. Signed-off-by: Miguel Ojeda <[email protected]>
ojeda
force-pushed
the
doc-codegen-change
branch
from
82f69c3 to
3d4fded
Compare
|
New year, new round -- please take a look! |
33 tasks
|
Looks great, thanks! @bors r+ |
|
📌 Commit 3d4fded has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
Thanks to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Clippy does not guarantee the same codegen will be produced.
Therefore, it should not be used as an universal replacement for
rustc.See #8035.
Signed-off-by: Miguel Ojeda [email protected]
fixes #8035
changelog: document that Clippy may change codegen