Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle signs in exponents in numeric_literal::format() #7747

Merged
merged 2 commits into from
Oct 2, 2021

Conversation

Manishearth
Copy link
Member

Fixes #7744

changelog: Correctly handle signs in exponents in numeric_literal::format()

@rust-highfive
Copy link

r? @xFrednet

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 2, 2021
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 🙃

@xFrednet
Copy link
Member

xFrednet commented Oct 2, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Oct 2, 2021

📌 Commit 6bf5c0b has been approved by xFrednet

@bors
Copy link
Contributor

bors commented Oct 2, 2021

⌛ Testing commit 6bf5c0b with merge da3b4b4...

@bors
Copy link
Contributor

bors commented Oct 2, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing da3b4b4 to master...

@bors bors merged commit da3b4b4 into rust-lang:master Oct 2, 2021
@Manishearth Manishearth deleted the excessive-precision branch October 2, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

excessive_precision formats large negative exponent wrong
4 participants