-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make approx_const
MSRV aware
#7629
Conversation
r? @xFrednet (rust-highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the work, your changes already look excellent. I've just found two NITs that should be addressed before merging this 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you very much for the update 🙃
@bors r+ |
📌 Commit 19d8a3e has been approved by |
Make `approx_const` MSRV aware changelog: [`approx_const`]: Add MRSV checks for LOG10_2 and LOG2_10. Fixes #7623
💔 Test failed - checks-action_test |
@bors retry |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
changelog: [
approx_const
]: Add MRSV checks for LOG10_2 and LOG2_10.Fixes #7623