Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use avoid-breaking-exported-api configuration in types module #7560

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Use avoid-breaking-exported-api configuration in types module #7560

merged 3 commits into from
Aug 12, 2021

Conversation

xFrednet
Copy link
Member

This PR empowers our lovely avoid-breaking-exported-api configuration value to also influence the emission of lints inside the types module.

(That's pretty much it, not really a change worthy of writing a fairy tale about. Don't get me wrong, I would love to write a short one, but I sadly need to study now).

Closes: #7489

changelog: The avoid-breaking-exported-api configuration now also works for [box_vec], [redundant_allocation], [rc_buffer], [vec_box], [option_option], [linkedlist], [rc_mutex]

changelog: [rc_mutex]: update the lint message to comply with the normal format

r? @camsteffen, as you implemented the configuration value

cc: @flip1995, as we've discussed this change in #7308

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 12, 2021
@xFrednet xFrednet force-pushed the 7289-configuration-for-every-type-lint branch from 309af43 to e67c25d Compare August 12, 2021 12:10
camsteffen
camsteffen suggested changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@camsteffen camsteffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! Just some nits. Glad to see the config option extended.

(That's pretty much it, not really a change worthy of writing a fairy tale about. Don't get me wrong, I would love to write a short one, but I sadly need to study now).

Also this PR is blocked on missing fairy tale. 🤣

clippy_utils/src/lib.rs Outdated Show resolved Hide resolved
clippy_lints/src/types/mod.rs Outdated Show resolved Hide resolved
clippy_lints/src/types/mod.rs Outdated Show resolved Hide resolved
clippy_lints/src/types/mod.rs Show resolved Hide resolved
@xFrednet
Copy link
Member Author

(That's pretty much it, not really a change worthy of writing a fairy tale about. Don't get me wrong, I would love to write a short one, but I sadly need to study now).

Also this PR is blocked on missing fairy tale. 🤣

It wouldn't be the first Clippy PR with a fairy tale 😉. I can promise you that the next PR I assign to you will have a short one in it. Does this sound like a deal to you?

camsteffen
camsteffen approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@camsteffen camsteffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you want to squash any commits?

@camsteffen
Copy link
Contributor

I can promise you that the next PR I assign to you will have a short one in it. Does this sound like a deal to you?

Oh alright 😄

@xFrednet xFrednet force-pushed the 7289-configuration-for-every-type-lint branch from 8465ba8 to c02dcd5 Compare August 12, 2021 20:19
@xFrednet
Copy link
Member Author

Looks good. Do you want to squash any commits?

Sure, why not 🙃

@bors r=camsteffen

@bors
Copy link
Contributor

bors commented Aug 12, 2021

📌 Commit c02dcd5 has been approved by camsteffen

@bors
Copy link
Contributor

bors commented Aug 12, 2021

⌛ Testing commit c02dcd5 with merge b4d76b4...

@bors
Copy link
Contributor

bors commented Aug 12, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing b4d76b4 to master...

@bors bors merged commit b4d76b4 into rust-lang:master Aug 12, 2021
@xFrednet xFrednet deleted the 7289-configuration-for-every-type-lint branch August 18, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camsteffen camsteffen camsteffen approved these changes

Assignees

@camsteffen camsteffen

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use avoid_breaking_public_api configuration in types module
4 participants
@xFrednet @camsteffen @bors @rust-highfive