fix bug on mutable ref #7533
fix bug on mutable ref #7533
Conversation
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Thank you for pinging me, glad to see that you got it working 🙃 . Could you update the PR description to include a changelog entry for this update and add a line like One more thing, Rust has a no merge policy that Clippy also tries to follow. Could you rebase your commit on master and remove the merge commit from this branch? 🙃 |
Valentine-Mario
force-pushed
the
vec_extend_to_append
branch
from
dd7190d to
472e655
Compare
There was a problem hiding this comment.
The rest looks good.
Thank you for addressing my comment about the description and commits. For the next time, it would be nice if you could give a bit more context in the commit message what actually got fixed 🙃.
I'm okay with merging this when my comments have been updated 👍
Valentine-Mario
force-pushed
the
vec_extend_to_append
branch
from
472e655 to
8a4ffb8
Compare
|
Awesome, the code looks good to me! As a last step. Could you add a change log entry to your PR description like this: You can just describe the change like: "Improved suggestion for mutable references" or something similar. You can ping me once you're done to merge this 🙃 |
|
📌 Commit 8a4ffb8 has been approved by |
|
@bors retry |
|
bors seems to be broken right now? https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/bors.20doesn't.20trigger.20auto.20CI.20on.20libc/near/248506490 |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes: #7524
This PR is related to issue #7524
changelog: [
extend_with_drain] Improve code suggestion for mutable and immutable references