Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Result on map_flatten lint #7522

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Cover Result on map_flatten lint #7522

merged 1 commit into from
Aug 2, 2021

Conversation

dswij
Copy link
Member

@dswij dswij commented Aug 1, 2021

Closes #7496

changelog: [map_flatten] handles Result type

Adds a check on `.map(..).flatten()` on `Result` type that follows the
behaviour on `Option` type.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 1, 2021
@llogiq
Copy link
Contributor

llogiq commented Aug 2, 2021

Thank you for the PR! Bonus points for extending the test. @bors r+

@bors
Copy link
Contributor

bors commented Aug 2, 2021

📌 Commit 69d4390 has been approved by llogiq

@bors
Copy link
Contributor

bors commented Aug 2, 2021

⌛ Testing commit 69d4390 with merge 4e760b6...

@bors
Copy link
Contributor

bors commented Aug 2, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 4e760b6 to master...

@bors bors merged commit 4e760b6 into rust-lang:master Aug 2, 2021
@dswij dswij deleted the map-flatten-result branch August 2, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map_flatten does not cover Result.map
4 participants