Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message for not_unsafe_ptr_arg_deref lint #7294

Merged
merged 1 commit into from
May 31, 2021
Merged

Improve message for not_unsafe_ptr_arg_deref lint #7294

merged 1 commit into from
May 31, 2021

Conversation

stevenengler
Copy link
Contributor

@stevenengler stevenengler commented May 31, 2021

changelog: Improved message for the ['not_unsafe_ptr_arg_deref'] lint

Doesn't close any issue, but implements a suggestion from #3045 (comment).

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 31, 2021
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 31, 2021

📌 Commit 58491d3 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented May 31, 2021

⌛ Testing commit 58491d3 with merge 860cb8f...

@bors
Copy link
Contributor

bors commented May 31, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 860cb8f to master...

@bors bors merged commit 860cb8f into rust-lang:master May 31, 2021
@stevenengler stevenengler deleted the unsafe-ptr-deref-msg branch May 31, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants