Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use_self FPs on type params #7288

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Fix use_self FPs on type params #7288

merged 2 commits into from
Jun 14, 2021

Conversation

camsteffen
Copy link
Contributor

changelog: Fix [use_self] false positives on type parameters

Fixes #4140
Fixes #7139

@rust-highfive
Copy link

r? @phansch

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 27, 2021
@phansch
Copy link
Member

phansch commented Jun 14, 2021

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Jun 14, 2021

📌 Commit 29b4b4c has been approved by phansch

@bors
Copy link
Contributor

bors commented Jun 14, 2021

⌛ Testing commit 29b4b4c with merge 6379d26...

@bors
Copy link
Contributor

bors commented Jun 14, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing 6379d26 to master...

@bors bors merged commit 6379d26 into rust-lang:master Jun 14, 2021
@camsteffen camsteffen deleted the use-self2 branch July 8, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for use_self with trait bounds Suggestion does not compile: use self with associated types
4 participants