Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the default lint level to the metadata collection #7246

Merged
merged 2 commits into from
May 19, 2021

Conversation

xFrednet
Copy link
Member

@xFrednet xFrednet commented May 19, 2021

I noticed while working on the website adaption that the lint groups still had the clippy:: prefix in the JSON output. This PR removes this prefix and adds a level field to each lint and with that simplifies the website display and saves performance.

The deprecated lints get are assigned to the level none. This is a bit different in comparison to the current lint list, but I believe that this will look better overall. Unless there is any argument against this :).

That's it just a small baby PR in comparison to the original monster ^^


See: #7172 for the full metadata collection to-do list or to suggest a new feature in connection to it.


changelog: none

r? @flip1995

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 19, 2021
And stripping the clippy:: prefix from the group
@xFrednet xFrednet force-pushed the 7172-add-lint-level-to-output branch from 551a5e6 to 8036d7f Compare May 19, 2021 14:42
@xFrednet
Copy link
Member Author

I'm back home and can finally compile Clippy again. The configuration changes from the last PR are all working as expected, yay ^^. And this small addition is my dive back into the code base.

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the typo.

@flip1995
Copy link
Member

@bors delegate+

@bors
Copy link
Collaborator

bors commented May 19, 2021

✌️ @xFrednet can now approve this pull request

@flip1995
Copy link
Member

r=me with typo fixed

Co-authored-by: Philipp Krones <[email protected]>
@xFrednet
Copy link
Member Author

@bors r=flip1995

@bors
Copy link
Collaborator

bors commented May 19, 2021

📌 Commit 9dc366b has been approved by flip1995

@bors
Copy link
Collaborator

bors commented May 19, 2021

⌛ Testing commit 9dc366b with merge 2d597b7...

@bors
Copy link
Collaborator

bors commented May 19, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 2d597b7 to master...

@bors bors merged commit 2d597b7 into rust-lang:master May 19, 2021
@xFrednet xFrednet deleted the 7172-add-lint-level-to-output branch July 28, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants