Stop linting else if let pattern in [option_if_let_else] lint
#7216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
llogiq
reviewed
May 17, 2021
| if arms.len() == 2; | ||
| if !is_result_ok(cx, cond_expr); // Don't lint on Result::ok because a different lint does it already | ||
| if let PatKind::TupleStruct(struct_qpath, &[inner_pat], _) = &arms[0].pat.kind; | ||
| if is_lang_ctor(cx, struct_qpath, OptionSome); | ||
| if let PatKind::Binding(bind_annotation, _, id, _) = &inner_pat.kind; | ||
| if !contains_return_break_continue_macro(arms[0].body); | ||
| if !contains_return_break_continue_macro(arms[1].body); | ||
|
|
There was a problem hiding this comment.
What's that empty line for?
There was a problem hiding this comment.
Oh! that's en habit for readability, I should have discard it before pushing, sorry
|
Regardless of the empty line, this is a good improvement. And I don't think an empty line should matter that much. So @bors r+ from my side. |
|
📌 Commit 368e621 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bors
added a commit
that referenced
this pull request
May 17, 2021
Remove dead code after #7216 changelog: none
bors
added a commit
that referenced
this pull request
May 17, 2021
Remove dead code after #7216 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For readability concerns, it is counterproductive to lint
else if letpattern.Unfortunately the suggested code is much less readable.
Fixes: #7006
changelog: stop linting
else if letpattern in [option_if_let_else] lint