Remove powi, "square can be computed more efficiently" #7201
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
| span_lint_and_sugg( | ||
| cx, | ||
| SUBOPTIMAL_FLOPS, | ||
| parent.span, | ||
| "square can be computed more efficiently", | ||
| "consider using", | ||
| format!( | ||
| "{}.mul_add({}, {})", | ||
| Sugg::hir(cx, &args[0], ".."), | ||
| Sugg::hir(cx, &args[0], ".."), | ||
| Sugg::hir(cx, other_addend, ".."), | ||
| ), | ||
| Applicability::MachineApplicable, | ||
| ); |
There was a problem hiding this comment.
Why does this case also removed?
There was a problem hiding this comment.
It is just a special case for
Should we keep it?
There was a problem hiding this comment.
In the related issue, I found that the case of x * x was discussed, but I couldn't find the discussion of mul_add. So I don't know why this case needs to be removed as same.
If there is no reason, I think it would be better to keep it.
giraffate
added
S-waiting-on-author
|
@giraffate I did some changes. Should we keep the same names for everything? |
powi(2) produces exactly the same native code as x * x
|
@giraffate All done. |
|
@bors r+ Thanks! |
|
📌 Commit be540e6 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
powi(2) produces exactly the same native code as x * x
powi was part of the [
suboptimal_flops] lintfixes #7058
changelog: Remove powi [
suboptimal_flops], "square can be computed more efficiently"