Unused io amount detects .read().ok()?
#7100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @camsteffen (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ABouttefeux
force-pushed
the
unused_io_amount
branch
from
55f4564 to
a149488
Compare
camsteffen
suggested changes
Apr 16, 2021
camsteffen
reviewed
Apr 16, 2021
camsteffen
approved these changes
Apr 22, 2021
ABouttefeux
force-pushed
the
unused_io_amount
branch
from
56bb890 to
3544966
Compare
|
Please don't reference the squashed commits in the commit message. I believe those commits can become garbage collected (unavailable) in the future, and there is no need to record the PR review history. Though we would keep commits separate if there are multiple, distinct changes in the PR. |
ABouttefeux
force-pushed
the
unused_io_amount
branch
from
3544966 to
5625d58
Compare
|
@bors r+ thanks! |
|
📌 Commit 5625d58 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7096
changelog: unused_io_amount now detect expertion like
.read().ok()?,.read().or_else(|err| ...)?and similar expressions.