Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useless use of format! should return function directly #7092

Merged
merged 1 commit into from
Apr 19, 2021
Merged

useless use of format! should return function directly #7092

merged 1 commit into from
Apr 19, 2021

Conversation

basavesh
Copy link
Contributor

@basavesh basavesh commented Apr 15, 2021 •
edited by giraffate
Loading

fixes #7066

changelog: [useless_format] wraps the content in the braces when it's needed.

r? @giraffate

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 15, 2021
basavesh
basavesh commented Apr 15, 2021
View reviewed changes
clippy_lints/src/format.rs Outdated Show resolved Hide resolved
giraffate
giraffate suggested changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work, and welcome to Clippy!

Parentheses should be put only when it's needed, not all. maybe_par method in utils may be useful for this case.

Also, Can a test like the one described in the related issue be added?

@giraffate giraffate added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Apr 16, 2021
@basavesh basavesh mentioned this pull request Apr 16, 2021
Closed
@basavesh
Copy link
Contributor Author

fixes #7078

giraffate
giraffate approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thanks!

Can you squash commits?

@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Apr 19, 2021

📌 Commit c6b381c has been approved by giraffate

@bors
Copy link
Contributor

bors commented Apr 19, 2021

⌛ Testing commit c6b381c with merge b7c12f3...

@bors
Copy link
Contributor

bors commented Apr 19, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing b7c12f3 to master...

@bors bors merged commit b7c12f3 into rust-lang:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giraffate giraffate giraffate approved these changes

Assignees

@giraffate giraffate

Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useless use of format!: should return function directly
4 participants
@basavesh @rust-highfive @giraffate @bors