search_is_some: add checking for is_none()
#6942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
mgacek8
force-pushed
the
issue_6815_search_is_none
branch
from
a65b0d5 to
37e6298
Compare
|
This looks mostly good. However I no longer see a |
|
imo it would be fine to to keep the original lint name 🤔 |
|
We use |
mgacek8
force-pushed
the
issue_6815_search_is_none
branch
from
37e6298 to
2ffee89
Compare
|
Thanks for the info! I restored the original name then :) |
mgacek8
changed the title
is_none() and thus rename the lint to search_is_some_or_noneis_none()
|
Thank you! @bors r+ |
|
📌 Commit 2ffee89 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #6815
changelog: search_is_some: add checking for
is_none().To be honest I don't know what is the process of renaming the lints. Appreciate any feedback if that needs to be handled differently. Thanks!