-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FP in single_component_path_imports
lint
#6905
Fix FP in single_component_path_imports
lint
#6905
Conversation
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
566384e
to
9ecb70a
Compare
9ecb70a
to
b018bca
Compare
b018bca
to
47f2c84
Compare
r? @giraffate |
9ce739a
to
6985d13
Compare
@bors r+ It looks good, thanks! |
📌 Commit 81dfb9e has been approved by |
…ffate Fix FP in `single_component_path_imports` lint Fix FP in `single_component_path_imports` lint when the import is reused with `self`, like in `use self::module`. Fixes #5210 changelog: none
💥 Test timed out |
@bors retry |
…ffate Fix FP in `single_component_path_imports` lint Fix FP in `single_component_path_imports` lint when the import is reused with `self`, like in `use self::module`. Fixes #5210 changelog: none
💔 Test failed - checks-action_test |
@bors retry |
…ffate Fix FP in `single_component_path_imports` lint Fix FP in `single_component_path_imports` lint when the import is reused with `self`, like in `use self::module`. Fixes #5210 changelog: none
💔 Test failed - checks-action_test |
Oh, the test fails because of ICE, I missed it. I will check it later. |
Did this also the fix the case of
|
@djc, no I don't think this case is handled, but feel free to provide a playground, and I will take a look at this. |
@bors r+ Thanks! |
📌 Commit 297e84f has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Fix FP in
single_component_path_imports
lint when the import is reused withself
, like inuse self::module
.Fixes #5210
changelog: none