Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix manual_map suggestion for if let.. else ... if let.. else chain #6856

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Fix manual_map suggestion for if let.. else ... if let.. else chain #6856

merged 1 commit into from
Mar 17, 2021

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Mar 5, 2021

fixes: #6847

changelog: Fix manual_map suggestion for if let.. else ... if let.. else chain

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 5, 2021
@Jarcho Jarcho force-pushed the manual_map_if_let branch from 404665f to 5b4b7bc Compare March 5, 2021 21:27
Manishearth
Manishearth approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach seems good, the util function should be in utils and documented though

clippy_lints/src/manual_map.rs Outdated Show resolved Hide resolved
@bors
Copy link
Contributor

bors commented Mar 15, 2021

☔ The latest upstream changes (presumably #6907) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho Jarcho force-pushed the manual_map_if_let branch from 5b4b7bc to 132c090 Compare March 16, 2021 17:50
@bors
Copy link
Contributor

bors commented Mar 17, 2021

☔ The latest upstream changes (presumably #6918) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho Jarcho force-pushed the manual_map_if_let branch from 132c090 to f468d82 Compare March 17, 2021 16:58
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 17, 2021

📌 Commit f468d82 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Mar 17, 2021

⌛ Testing commit f468d82 with merge ba13311...

@bors
Copy link
Contributor

bors commented Mar 17, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing ba13311 to master...

@bors bors merged commit ba13311 into rust-lang:master Mar 17, 2021
@Jarcho Jarcho mentioned this pull request Mar 25, 2021
Closed
@Jarcho Jarcho deleted the manual_map_if_let branch April 6, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees

@Manishearth Manishearth

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

manual_map suggestion cannot be applied: if let.. else if let .. chain
4 participants
@Jarcho @rust-highfive @bors @Manishearth