upper_case_acronyms: don't warn on public items

[matthiaskrgr]

Fixes #6803

changelog: upper_case_acronyms: ignore public items

[rust-highfive]

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

[ghost]

Are these items still linted if you set the aggressive option on?

[matthiaskrgr]

According to the ui-toml-test no.

[ghost]

Why remove them from the aggressive mode as well?

[matthiaskrgr]

Because it still breaks the api if public types are renamed, regardless of the case.

[ghost]

For this particular lint, I'm pretty sure that you want those warnings if you turn on aggressive mode.

[matthiaskrgr]

The aggressive mode was about warning about ASTString vs ASTSTRING, this is about false positives in public items and not related imo.

[flip1995]

I agree, that the aggressive mode of this lint shouldn't change this behavior. This should be addressed, once #6806 is implemented.

@bors r+

[bors]

📌 Commit 9dba6a9 has been approved by flip1995

[bors]

⌛ Testing commit 9dba6a9 with merge 8af2884...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8af2884 to master...