Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more lintcheck updates #6744

Merged
merged 7 commits into from
Feb 16, 2021
Merged

more lintcheck updates #6744

merged 7 commits into from
Feb 16, 2021

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Feb 15, 2021

  • do some refactoring and renaming here and there
  • add comments to functions
  • fix bug where git repos would not get checked out to the proper commits (cmd was not actually run in repo directory 😅 )
  • print warnings if we can't clone or check out a git repo
  • filter out noise from cargo-metadata errors and lint messages that contained absolute file paths (these would change with every pinned-nightly bump, polluting the logs)

changelog: more lintcheck refactoring and fixes for git crates

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 15, 2021
…r contain absolute paths to rustc source files

The latter is especially annoying because the paths would change every time we bumped the pinned nightly version.
@matthiaskrgr
Copy link
Member Author

r? @flip1995

@rust-highfive rust-highfive assigned flip1995 and unassigned llogiq Feb 15, 2021
@flip1995
Copy link
Member

@bors r+

Thanks!


I had the idea this morning, to add a configuration option to a crate source, that lets you specify lint levels that should be passed over command line. If not provided the default all+pedantic is used.

@bors
Copy link
Contributor

bors commented Feb 16, 2021

📌 Commit a95c250 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Feb 16, 2021

⌛ Testing commit a95c250 with merge f28c54c...

@bors
Copy link
Contributor

bors commented Feb 16, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing f28c54c to master...

@bors bors merged commit f28c54c into rust-lang:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants