Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not lint when the closure is called using an iterator #6741

Merged
merged 1 commit into from
Feb 14, 2021

Conversation

ThibsG
Copy link
Contributor

@ThibsG ThibsG commented Feb 14, 2021

Fix FP when the closure is used in an iterator for blocks_in_if_conditions lint

FIxes: #1141

changelog: none

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 14, 2021
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Feb 14, 2021

📌 Commit 1202550 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Feb 14, 2021

⌛ Testing commit 1202550 with merge 2f19f5f...

@bors
Copy link
Collaborator

bors commented Feb 14, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 2f19f5f to master...

@bors bors merged commit 2f19f5f into rust-lang:master Feb 14, 2021
@ThibsG ThibsG deleted the BlockInIfConditions1141 branch February 14, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

block_in_if_condition_stmt: false positive with blocks inside iterator method calls
4 participants