Cleanup path-to-local checks #6660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #6646) made this pull request unmergeable. Please resolve the merge conflicts. |
camsteffen
force-pushed
the
path-to-local
branch
from
1866672 to
56f7fbb
Compare
|
Sorry for taking so long to review. @bors r+ |
|
📌 Commit 56f7fbb has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: none
It seemed like too much ceremony going on to check if an expression matches a variable. So I created two util functions
path_to_local(Expr) -> Option<HirId>andpath_to_local_id(Expr, HirId) -> boolto make this easier, and used them wherever applicable.I changed logic in a few places to use
HirIdinstead ofSymbolwhere it was easy to do so. I believe this is more correct and may even fix some bugs.I also removed some calls to
qpath_res. This is not needed if you are only looking for aRes::Local.As a note, I wanted to name the util functions in a way that encourages understanding of the HIR.