Improve collapsible_match #6619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @phansch (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
camsteffen
force-pushed
the
collapsible-match
branch
from
1edf9f3 to
3e0a088
Compare
|
I tweaked my approach. |
Manishearth
approved these changes
Jan 22, 2021
|
@bors delegate+ |
|
✌️ @camsteffen can now approve this pull request |
bors
added a commit
that referenced
this pull request
Jan 22, 2021
Improve collapsible_match changelog: Fix collapsible_match false negatives Allow `&` and/or `*` on the binding and make sure the type still matches.
|
@bors r- whoops, since when reacts bors to commands in discussion comments in code blocks? 😮 |
|
☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
camsteffen
force-pushed
the
collapsible-match
branch
from
3e0a088 to
50abde2
Compare
|
@bors r+ and have a nice day |
|
📌 Commit 50abde2 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
thanks @bors, ttyl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Fix collapsible_match false negatives
Allow
&and/or*on the binding and make sure the type still matches.