Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly document false positives #6585

Merged
merged 1 commit into from
Jan 17, 2021
Merged

Explicitly document false positives #6585

merged 1 commit into from
Jan 17, 2021

Conversation

Daniel-B-Smith
Copy link

@Daniel-B-Smith Daniel-B-Smith commented Jan 13, 2021 •
edited by flip1995
Loading

Adds documentation for known false positives for the await_holding* lints.

Issues:

#6353
#6446

changelog: document FPs for the await_holding_* lints

@rust-highfive
Copy link

r? @ebroto

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 13, 2021
@Daniel-B-Smith Daniel-B-Smith mentioned this pull request Jan 13, 2021
Open
@ebroto
Copy link
Member

ebroto commented Jan 16, 2021

r? @flip1995 (I'm leaving the team, so I'm reassigning my PRs to other active members)

@rust-highfive rust-highfive assigned flip1995 and unassigned ebroto Jan 16, 2021
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jan 17, 2021

📌 Commit 02f99be has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jan 17, 2021

⌛ Testing commit 02f99be with merge a61fa63...

bors added a commit that referenced this pull request Jan 17, 2021
@bors
Auto merge of #6585 - Daniel-B-Smith:false-positive-issue, r=flip1995
a61fa63 
Explicitly document false positives

Adds documentation for known false positives for the `await_holding*` lints.

Issues:

#6353
#6446
@bors
Copy link
Contributor

bors commented Jan 17, 2021

💔 Test failed - checks-action_test

@flip1995
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Jan 17, 2021

⌛ Testing commit 02f99be with merge 91292f1...

@bors
Copy link
Contributor

bors commented Jan 17, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 91292f1 to master...

@bors bors merged commit 91292f1 into rust-lang:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Daniel-B-Smith @rust-highfive @ebroto @flip1995 @bors