Similar names ignore underscore prefixed names #6403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
camsteffen
force-pushed
the
similar-names-underscore
branch
from
7cfb069 to
5c24c73
Compare
|
@bors r+ |
|
📌 Commit 5c24c73 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 30, 2020
Similar names ignore underscore prefixed names changelog: Ignore underscore-prefixed names for similar_names IMO, this lint is not very helpful for underscore-prefixed variables. Usually they are unused or are just there to ignore part of a destructuring.
|
💔 Test failed - checks-action_dev_test |
camsteffen
force-pushed
the
similar-names-underscore
branch
from
5c24c73 to
f2d4935
Compare
|
@bors r=Manishearth Let's see if bors likes me. |
|
@camsteffen: 🔑 Insufficient privileges: Not in reviewers |
|
@bors sudo r+ |
|
@bors delegate+ r+ it's per-PR :) |
|
✌️ @camsteffen can now approve this pull request |
|
📌 Commit f2d4935 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Ignore underscore-prefixed names for similar_names
IMO, this lint is not very helpful for underscore-prefixed variables. Usually they are unused or are just there to ignore part of a destructuring.