Lint usage of Debug-based formatting
#637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any comment on that one? |
|
Too much to look at from mobile; it'll have to wait until the afternoon. |
| } | ||
| } | ||
|
|
||
| impl fmt::Display for Constant { |
There was a problem hiding this comment.
Is there a specific reason for removing this (apart from it using Debug formatting to write out Strs)?
There was a problem hiding this comment.
It was used only once, only to print integers. After I refactored the loop lint to use const_eval it wasn’t used anymore and seemed of little use, if the user wrote 6*7 in an expression, they must have a reason not to have written 42, a snippet should always be used to print the original expression.
|
Apart from one question, looks good to me. |
llogiq
added a commit
that referenced
this pull request
Feb 12, 2016
Lint usage of `Debug`-based formatting
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #634.
Ref #461.
Ref #442.