Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example used in cargo_common_metadata #6293

Merged
merged 1 commit into from
Nov 8, 2020

Conversation

Urcra
Copy link
Contributor

@Urcra Urcra commented Nov 4, 2020

The previous example used in cargo_common_metadata included an authors field, even though the comment says it doesn't. And thus doesn't actually demonstrate an example of how the lint fails.

This removes that authors field from the bad example and suggest to fix the bad example by adding the authors field

changelog: Fix example used in cargo_common_metadata

@rust-highfive
Copy link

r? @flip1995

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 4, 2020
@flip1995
Copy link
Member

flip1995 commented Nov 8, 2020

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Nov 8, 2020

📌 Commit a4acb31 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Nov 8, 2020

⌛ Testing commit a4acb31 with merge 7079de9...

@bors
Copy link
Contributor

bors commented Nov 8, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 7079de9 to master...

@bors bors merged commit 7079de9 into rust-lang:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants