Lint unnecessary int-to-int and float-to-float casts #6187
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ebroto (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
ebroto
added
S-waiting-on-author
|
The problem with the CI is that the fixed file fails to compile. You can avoid the error by using a let binding, e.g. let _ = -1 as i32; |
|
@bors r+ Thanks! |
|
📌 Commit d46edd9 has been approved by |
Lint unnecessary int-to-int and float-to-float casts This is an implementation of a lint that detects unnecessary casts of number literals, as discussed here: #6116 --- changelog: lint unnecessary as-casts of literals when they could be written using literal syntax.
|
💔 Test failed - checks-action_test |
|
It seems keeping the separators broke tests for another lint. I think that's an improvement so we should just update the stderr files for that lint |
|
@bors r+ |
|
📌 Commit 71ac0c0 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This is an implementation of a lint that detects unnecessary casts of number literals, as discussed here:
#6116
changelog: lint unnecessary as-casts of literals when they could be written using literal syntax.