Downgrade interior_mutable_const lints to warn by default #6098
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ebroto (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
There was a problem hiding this comment.
I also had a problem where the stderr of the tests didn't change despite me changing both lints to warn by default. Is this normal behaviour for some lints or do I need to adjust the tests to accommodate the change?
This is because the tests were already setting the lint level to warning for those lints. Don't worry, you don't need to change anything related to that.
ebroto
added
S-waiting-on-author
There was a problem hiding this comment.
LGTM, thanks for your contribution!
There were some revert commits, so I went ahead and squashed the commits into one. You are still the author, of course :)
I went for doing it myself because last time you ran into some problems and I didn't want your work to go to waste, but for the future you can find here some cool instructions about how to do that.
|
@bors r+ |
|
📌 Commit 8b8c63f has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
Bless your soul my friend, thanks a bunch for the help! |
This change updates the two lints in the file non_copy_const.rs to be warn by default rather than deny by default. It also updates the known problems for declare_interior_mutable_const to mention some issues that are affected by the lints.
This is a repeat pull request since I botched the first one (#6012). Apart from my messing up the commits of that one, I also had a problem where the stderr of the tests didn't change despite me changing both lints to warn by default. Is this normal behaviour for some lints or do I need to adjust the tests to accommodate the change?
fixes #5863
changelog: none