-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify margin of error in wording of float comparison operator lint messages #6043
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matthiaskrgr (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
I think the |
Hi @fvsch thanks for the comment but I couldn't find another place in the code where float_cmp_const needs to be changed. I am also not sure where I need to go to edit the examples. Please could you point me in the right direction for these? Happy to make the changes, but new to the repo and searching doesn't seem to turn anything up. |
@HaramanJohal the lint docs are at the top of the misc.rs file rust-clippy/clippy_lints/src/misc.rs Line 105 in 12ce312
|
Thanks! @bors r+ |
📌 Commit 16b6ceb has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes #6040
changelog: change wording of float comparison operator to make margin of error less ambiguous