Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useless_attribute: Permit wildcard_imports and enum_glob_use #5994

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Sep 1, 2020

Fixes #5918

changelog: useless_attribute: Permit wildcard_imports and enum_glob_use on use items

@rust-highfive
Copy link

r? @Manishearth

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 1, 2020
@phansch
Copy link
Member

phansch commented Sep 3, 2020

r? @phansch

@rust-highfive rust-highfive assigned phansch and unassigned Manishearth Sep 3, 2020
@phansch
Copy link
Member

phansch commented Sep 3, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 3, 2020

📌 Commit 2e4b4ce has been approved by phansch

@bors
Copy link
Collaborator

bors commented Sep 3, 2020

⌛ Testing commit 2e4b4ce with merge 8829214...

@bors
Copy link
Collaborator

bors commented Sep 3, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing 8829214 to master...

@bors bors merged commit 8829214 into rust-lang:master Sep 3, 2020
@taiki-e taiki-e deleted the useless_attribute branch September 3, 2020 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for the useless_attribute rule
5 participants