Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation related to the sync process #5947

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

ebroto
Copy link
Member

@ebroto ebroto commented Aug 23, 2020

Rendered

r? @flip1995

changelog: none

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 23, 2020
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few NITs

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Aug 25, 2020

📌 Commit b05077e has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Aug 25, 2020

⌛ Testing commit b05077e with merge 49ded16...

bors added a commit that referenced this pull request Aug 25, 2020
@flip1995
Copy link
Member

@bors retry (yeet; we need a bors yeet command)

@bors
Copy link
Collaborator

bors commented Aug 25, 2020

⌛ Testing commit b05077e with merge ba43a43...

@bors
Copy link
Collaborator

bors commented Aug 25, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing ba43a43 to master...

@bors bors merged commit ba43a43 into rust-lang:master Aug 25, 2020
@ebroto ebroto deleted the rustup_doc_improvements branch August 25, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants