Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false negative in option_as_ref_deref #5933

Merged
merged 1 commit into from Aug 22, 2020
Merged

Fix false negative in option_as_ref_deref #5933

merged 1 commit into from Aug 22, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 21, 2020

Closes #5927

changelog: Fix false negative in option_as_ref_deref

@rust-highfive
Copy link

r? @matthiaskrgr

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 21, 2020
@matthiaskrgr
Copy link
Member

@bors r+
Thanks!

@bors
Copy link
Contributor

bors commented Aug 21, 2020

📌 Commit 11efd75 has been approved by matthiaskrgr

@bors
Copy link
Contributor

bors commented Aug 21, 2020

⌛ Testing commit 11efd75 with merge ef744ab...

bors added a commit that referenced this pull request Aug 21, 2020
Fix false negative in `option_as_ref_deref`

Closes #5927

changelog: Fix false negative in `option_as_ref_deref`
@bors
Copy link
Contributor

bors commented Aug 21, 2020

💔 Test failed - checks-action_test

@matthiaskrgr matthiaskrgr added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 21, 2020
@matthiaskrgr
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Aug 21, 2020

⌛ Testing commit 11efd75 with merge aa3b04f...

@bors
Copy link
Contributor

bors commented Aug 22, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: matthiaskrgr
Pushing aa3b04f to master...

@bors bors merged commit aa3b04f into rust-lang:master Aug 22, 2020
@ghost ghost deleted the fix-5927 branch August 22, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

option_as_ref_deref doesn't catch fully qualified direct calls to Deref::deref or DerefMut::deref_mut
3 participants