-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false negative in option_as_ref_deref
#5933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
label
Aug 21, 2020
matthiaskrgr
approved these changes
Aug 21, 2020
@bors r+ |
📌 Commit 11efd75 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 21, 2020
Fix false negative in `option_as_ref_deref` Closes #5927 changelog: Fix false negative in `option_as_ref_deref`
💔 Test failed - checks-action_test |
matthiaskrgr
added
S-waiting-on-bors
Status: The marked PR was approved and is only waiting bors
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
labels
Aug 21, 2020
@bors retry |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
ghost
deleted the
fix-5927
branch
August 22, 2020 05:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5927
changelog: Fix false negative in
option_as_ref_deref