Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo_dev: add ra-setup #5655

Merged
merged 1 commit into from
May 31, 2020
Merged

cargo_dev: add ra-setup #5655

merged 1 commit into from
May 31, 2020

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented May 27, 2020 •
edited
Loading

It takes an absolute path to a rustc repo and adds path-dependencies
that point towards the respective rustc subcrates into the Cargo.tomls of
the clippy and clippy_lints crate.

This allows rustc-analyzer to show proper type annotations etc on rustc-internals inside the clippy repo.

Usage: cargo dev ra-setup /absolute/path/to/rust/

cc rust-lang/rust-analyzer#3517
cc #5514

changelog: none

@rust-highfive
Copy link

r? @flip1995

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 27, 2020
@matthiaskrgr matthiaskrgr force-pushed the source_mod branch 2 times, most recently from 2ba355c to b2ab719 Compare May 27, 2020 18:40
flip1995
flip1995 reviewed May 27, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same idea recently. I wouldn't create a new crate for this, but add a new subcommand to clippy_dev. Maybe cargo dev ide-setup or just ide? (#5394)

source_injector/src/main.rs Outdated Show resolved Hide resolved
@matthiaskrgr
Copy link
Member Author

I integrated it into clippy-dev now, this is definitely the better approach. :)

@matthiaskrgr matthiaskrgr changed the title source injector: add the crate cargo_dev: add ra_setup May 28, 2020
@matthiaskrgr matthiaskrgr force-pushed the source_mod branch 2 times, most recently from 2adf22e to c17a2a9 Compare May 28, 2020 01:50
@matthiaskrgr
clippy_dev: add ra_setup
7b49090 
This takes an absolute path to a rustc repo and adds path-dependencies
that point towards the respective rustc subcrates into the Cargo.tomls of
the clippy and clippy_lints crate.

This allows rustc-analyzer to show proper type annotations etc on rustc-internals inside the clippy repo.

Usage: cargo dev ra-setup /absolute/path/to/rust/

cc rust-lang/rust-analyzer#3517
cc rust-lang#5514
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented May 28, 2020

📌 Commit 7b49090 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented May 28, 2020

⌛ Testing commit 7b49090 with merge 0d1e176...

bors added a commit that referenced this pull request May 28, 2020
@bors
Auto merge of #5655 - matthiaskrgr:source_mod, r=flip1995
0d1e176 
cargo_dev: add ra_setup

It takes an absolute path to a rustc repo and adds path-dependencies
that point towards the respective rustc subcrates into the Cargo.tomls of
the clippy and clippy_lints crate.

This allows rustc-analyzer to show proper type annotations etc on rustc-internals inside the clippy repo.

Usage: cargo dev ra-setup /absolute/path/to/rust/

cc rust-lang/rust-analyzer#3517
cc #5514

changelog: none
@bors
Copy link
Collaborator

bors commented May 28, 2020

💔 Test failed - checks-action_test

@matthiaskrgr matthiaskrgr added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels May 28, 2020
@matthiaskrgr matthiaskrgr changed the title cargo_dev: add ra_setup cargo_dev: add ra-setup May 28, 2020
@matthiaskrgr matthiaskrgr mentioned this pull request May 28, 2020
Merged
@flip1995
Copy link
Member

@bors retry

@bors
Copy link
Collaborator

bors commented May 31, 2020

⌛ Testing commit 7b49090 with merge 871f3ed...

@bors
Copy link
Collaborator

bors commented May 31, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 871f3ed to master...

@bors bors merged commit 871f3ed into rust-lang:master May 31, 2020
bors added a commit that referenced this pull request May 31, 2020
@bors
Auto merge of #5661 - matthiaskrgr:explain_ra_setup, r=phansch
544d937 
CONTRIBUTING: explain how to use cargo dev ra-setup

Fixes #5514

Technically this should be merged after #5655 but it's not very important.

---

changelog: none
bors added a commit that referenced this pull request May 31, 2020
@bors
Auto merge of #5661 - matthiaskrgr:explain_ra_setup, r=phansch
6c008d7 
CONTRIBUTING: explain how to use cargo dev ra-setup

Fixes #5514

Technically this should be merged after #5655 but it's not very important.

---

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 left review comments

Assignees

@flip1995 flip1995

Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthiaskrgr @rust-highfive @flip1995 @bors