Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No to_string in display #5574

Closed
wants to merge 9 commits into from
Closed

No to_string in display #5574

wants to merge 9 commits into from

Conversation

marcin-serwin
Copy link
Contributor

Fixes #3876

changelog:

  • added lint to-string-in-display

@marcin-serwin marcin-serwin changed the title No to string in display No to_string in display May 6, 2020
@flip1995
Copy link
Member

flip1995 commented May 7, 2020

Please also add the example in #4396 where a to_string method is implemented as just another method of a struct and then used in the Display implementation. As long as this is linted, I'm hesitant to make this lint enabled by default and would rather put it in nursery.

@flip1995 flip1995 added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label May 7, 2020
@flip1995
Copy link
Member

Friendly ping @Toxyxer. Did you have time to add the test case? If you need help with something, feel free to ask anytime.

@flip1995 flip1995 self-assigned this May 25, 2020
@flip1995
Copy link
Member

flip1995 commented Jun 7, 2020

ping from triage @Toxyxer. Thanks for contributing to Clippy! Sadly this PR didn't receive an update in the last 2 weeks. If you have more time to continue working on this, feel free to reopen.

@flip1995 flip1995 closed this Jun 7, 2020
@flip1995 flip1995 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties S-inactive-closed Status: Closed due to inactivity and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 7, 2020
@chansuke chansuke mentioned this pull request Jul 22, 2020
Merged
bors added a commit that referenced this pull request Aug 16, 2020
@bors
Auto merge of #5831 - chansuke:to_string_in_display, r=flip1995
a2d8331 
Don't use `to_string` in impl Display

fixes #3876

this PR is derived from [Toxyxer's implementation](#5574).
changelog: none
bors added a commit that referenced this pull request Aug 16, 2020
@bors
Auto merge of #5831 - chansuke:to_string_in_display, r=flip1995
e522ca3 
Don't use `to_string` in impl Display

fixes #3876

this PR is derived from [Toxyxer's implementation](#5574).
changelog: add [`to_string_in_display`] lint
@HKalbasi
Copy link
Member

finished in #5831
@rustbot label -S-inactive-closed

@rustbot rustbot removed the S-inactive-closed Status: Closed due to inactivity label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flip1995 flip1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correctness: no to_string in impl Display
4 participants
@marcin-serwin @flip1995 @HKalbasi @rustbot